signon-ui-0.15^20240205.eef943f-4.fc43

List of Findings

Error: COMPILER_WARNING (CWE-758): [#def1]
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:45:5: warning[-Wexpansion-to-defined]: this use of ‘defined’ may not be portable
#   45 | #if HAS_FOREIGN_QWINDOW
#      |     ^~~~~~~~~~~~~~~~~~~
#   43|   #include <X11/Xlib.h>
#   44|   #endif
#   45|-> #if HAS_FOREIGN_QWINDOW
#   46|   #include <QWindow>
#   47|   #endif

Error: COMPILER_WARNING (CWE-477): [#def2]
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp: scope_hint: In constructor ‘SignOnUi::RequestPrivate::RequestPrivate(const QDBusConnection&, const QDBusMessage&, const QVariantMap&, SignOnUi::Request*)’
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:113:37: warning[-Wdeprecated-declarations]: ‘QVariant::Type QVariant::type() const’ is deprecated: Use typeId() or metaType().
#  113 |         m_clientData = (variant.type() == QVariant::Map) ?
#      |                         ~~~~~~~~~~~~^~
/usr/include/qt6/QtDBus/qtdbusglobal.h:9: included_from: Included from here.
/usr/include/qt6/QtDBus/qdbusconnection.h:8: included_from: Included from here.
/usr/include/qt6/QtDBus/QDBusConnection:1: included_from: Included from here.
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.h:24: included_from: Included from here.
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:23: included_from: Included from here.
/usr/include/qt6/QtCore/qvariant.h:432:10: note: declared here
#  432 |     Type type() const
#      |          ^~~~
#  111|       if (parameters.contains(SSOUI_KEY_CLIENT_DATA)) {
#  112|           QVariant variant = parameters[SSOUI_KEY_CLIENT_DATA];
#  113|->         m_clientData = (variant.type() == QVariant::Map) ?
#  114|               variant.toMap() :
#  115|               qdbus_cast<QVariantMap>(variant.value<QDBusArgument>());

Error: COMPILER_WARNING (CWE-758): [#def3]
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:132:5: warning[-Wexpansion-to-defined]: this use of ‘defined’ may not be portable
#  132 | #if HAS_FOREIGN_QWINDOW
#      |     ^~~~~~~~~~~~~~~~~~~
#  130|       m_window = window;
#  131|   
#  132|-> #if HAS_FOREIGN_QWINDOW
#  133|       if (embeddedUi() && windowId() != 0) {
#  134|           TRACE() << "Requesting window embedding";

Error: COMPILER_WARNING (CWE-758): [#def4]
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:150:5: warning[-Wexpansion-to-defined]: this use of ‘defined’ may not be portable
#  150 | #if HAS_FOREIGN_QWINDOW
#      |     ^~~~~~~~~~~~~~~~~~~
#  148|       window->setModality(Qt::WindowModal);
#  149|       window->show();
#  150|-> #if HAS_FOREIGN_QWINDOW
#  151|       if (windowId() != 0) {
#  152|           TRACE() << "Requesting window reparenting";

Error: COMPILER_WARNING (CWE-477): [#def5]
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp: scope_hint: In member function ‘Accounts::Account* SignOnUi::RequestPrivate::findAccount()’
signon-ui-eef943f0edf3beee8ecb85d4a9dae3656002fc24/src/request.cpp:179:38: warning[-Wdeprecated-declarations]: ‘QVariant::QVariant(Type)’ is deprecated: Use the constructor taking a QMetaType instead.
#  179 |         QVariant value(QVariant::UInt);
#      |                                      ^
/usr/include/qt6/QtCore/qvariant.h:428:14: note: declared here
#  428 |     explicit QVariant(Type type)
#      |              ^~~~~~~~
#  177|           if (account == 0) continue;
#  178|   
#  179|->         QVariant value(QVariant::UInt);
#  180|           if (account->value("CredentialsId", value) != Accounts::NONE &&
#  181|               value.toUInt() == identity) {

Scan Properties